-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin: support system-wide plugins #4244
Open
magik6k
wants to merge
2
commits into
master
Choose a base branch
from
feat/global-plugins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Sep 17, 2017
Kubuxu
reviewed
Sep 17, 2017
40df1a5
to
9c753a4
Compare
dedc5ed
to
fa98b75
Compare
Got sharness to work, cc @Kubuxu |
Kubuxu
reviewed
Sep 26, 2017
fa98b75
to
4afb769
Compare
4afb769
to
4fee1b4
Compare
Kubuxu
requested changes
Oct 16, 2017
4fee1b4
to
cdbfbb4
Compare
cdbfbb4
to
afafbdb
Compare
Rebased on latest master |
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
afafbdb
to
5fae9a4
Compare
So this is potentially broken as it may try to load the preloaded plugins twice, with #4806 this should be easy to fix nicely |
@magik6k I've rebased and merged the linked PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4238.
I'm not exactly sure how to wire it to up sharness, cc @Kubuxu.