-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] S3 Datastore #5561
base: master
Are you sure you want to change the base?
[WIP] S3 Datastore #5561
Conversation
879866f
to
5aeb3d2
Compare
Need #5187 first |
plugin/plugins/s3ds/s3ds.go
Outdated
}, nil | ||
} | ||
|
||
type loggingDatastore struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There already is a logging datastore: https://github.com/ipfs/go-ipfs/blob/master/repo/fsrepo/datastores.go#L66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just starting to learn the codebase.
9e797c6
to
2e7b48a
Compare
I attempted to |
2e7b48a
to
947e604
Compare
Any idea if this would allow to run multiple IPFS nodes with a shared s3 datastore ? |
If you only use this for |
As an update, I rewrote |
b93f21b
to
b66a91b
Compare
b66a91b
to
027f339
Compare
License: MIT Signed-off-by: Edgar Lee <edgarl@netflix.com>
027f339
to
1526a4a
Compare
|
Should this ticket be closed in favor of making ipfs/go-ds-s3 in the default plugin list? |
Based on #5516
Related: #5235, ipfs/notes#214
This is some initial work to get S3 datastore working with IPFS.
Uses fork of
go-ds-s3
: ipfs/go-ds-s3#7I have tested this with an AWS S3 bucket. But
BloomFilterSize
must be set to a high number otherwise the daemon will send too manyGet
requests to S3.