-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pluggable keystores #6069
Draft
Stebalien
wants to merge
2
commits into
master
Choose a base branch
from
feat/pluggable-keystore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
pluggable keystores #6069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2019
89db07f
to
b72a340
Compare
Oh snap this is awesome! 🎆 Let me try and integrate the keystore I wrote today and see if I come across any unexpected issues. |
bonedaddy
reviewed
Mar 10, 2019
repo/fsrepo/fsrepo.go
Outdated
spec = map[string]interface{}{"type": "files", "path": "keystore"} | ||
} | ||
|
||
ksType, ok := spec["type"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experimenting with this locally gives me:
../../../../pkg/mod/github.com/ipfs/go-ipfs@v0.0.0-20190309025046-b72a340c987a/repo/fsrepo/fsrepo.go:397:25: cannot use ksType (type interface {}) as type string in map index: need type assertion
Might need to do ?
Suggested change
ksType, ok := spec["type"] | |
ksType, ok := spec["type"].(string) |
This patch allows keystores to be configured via the config and plugins. It's completely untested for now, but I started this so I figured I'd get it to a point where we could consider finishing it. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
9c97a9a
to
ab644a0
Compare
ping @Stebalien what's the status of this and is this something we still want? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows keystores to be configured via the config and plugins.
It's completely untested for now, but I started this so I figured I'd get it to a point where we could consider finishing it.
Depends on: ...
CC @postables