-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: 'ipfs swarm peering' command #8147
Conversation
|
Thank you for your comment. I understand. |
c4a7df6
to
e6424a2
Compare
d70ae1b
to
6721d11
Compare
@Stebalien ( @aschmahmann ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
3d459e3
to
2f6be1a
Compare
@TakashiMatsuda : let us know when this is ready to be looked at again. |
@BigLep Okay. Sorry I kept you waiting. I will finish in a few days. |
@BigLep @Stebalien |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ipfs/go-ipfs/pull/8147/files#r690637152 still needs to be addressed and I've added one help-text nit. Other than that, this looks great! And thanks for writing the tests.
Could you rebase on master one more time to fix the tests? |
Sure, can I |
Co-authored-by: Steven Allen <steven@stebalien.com>
Co-authored-by: Steven Allen <steven@stebalien.com>
Co-authored-by: Steven Allen <steven@stebalien.com>
Co-authored-by: Steven Allen <steven@stebalien.com>
3e8381a
to
dbdf103
Compare
Thanks @TakashiMatsuda 🙏 |
ListPeers does not hold a lock when reads from the |
Thanks for catching that! Fixed in #8438. |
* feat: added swarm peering command supporting add, ls and rm Co-authored-by: Steven Allen <steven@stebalien.com> (cherry picked from commit a651045)
* feat: added swarm peering command supporting add, ls and rm Co-authored-by: Steven Allen <steven@stebalien.com> (cherry picked from commit a651045)
Overview
This PR is intended to implement a part of #7880.
Detail
New command
ipfs swarm peering
is added in this commit.There are three subcommands under
ipfs swarm peering
. :Usage of 'ipfs swarm peering add'
Example:
Help text:
Usage of 'ipfs swarm peering rm'
Example:
Help text:
Usage of 'ipfs swarm peering ls'
Example:
Help text:
Comment
--save
option and the add command.ipfs swarm peering ls
command is not requested in [Enhancement] Dynamic Peerlist adding / removing #7880. Ifls
was unnecessary, I would remove it.