[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scheme and Lua client libraries #1707

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add Scheme and Lua client libraries #1707

merged 2 commits into from
Sep 25, 2023

Conversation

siiky
Copy link
Contributor
@siiky siiky commented Sep 22, 2023

Describe your changes

Now that #1695 has been merged, and #1194 closed, #1194 (comment) (previously ipfs/ipfs#480) can be taken care of.

Files changed

  • docs/reference/kubo-rpc-cli.md

Does this update depend on any other PRs?

No.

@welcome
Copy link
welcome bot commented Sep 22, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@siiky
Copy link
Contributor Author
siiky commented Sep 22, 2023

@ElPaisano maybe you can review, since you merged #1695

Copy link
Member
@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @siiky ❤️

@lidel lidel merged commit 9180d33 into ipfs:main Sep 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants