[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore check-wheel-content duplicate file error #7343

Merged
merged 2 commits into from
May 1, 2024

Conversation

RRosio
Copy link
Collaborator
@RRosio RRosio commented Apr 26, 2024

In attempting to make a release for 6.5.x, during jupyter-releaser check-python, check-wheel-content gives a duplicate file error: https://github.com/jupyter/notebook/actions/runs/8851516368/job/24308219469

@RRosio
Copy link
Collaborator Author
RRosio commented Apr 26, 2024

No new CI failures due to changes in this PR, however, it seems that the Python Tests CI failures on Macos, which were previously passing, are now failing due to macos-latest using macos-14 which uses M1 runners now, where previously the most recent CI tests had used, macos-12.7.3. If I understand correctly, based on the matrix for macos-14 currently support is only for Python versions 3.11 and 3.12.

I have specified the use of macos-12 in the Python Tests workflow for 6.5.x in another PR, currently a draft (#7344) which also aims to resolve other CI issues.

I was also wondering if the main branch may be affected as well, but I noticed it uses actions/setup-python@v5 while 6.5.x uses actions/setup-python@v1 and the issues in the actions/setup-python repo mention there was a recent fix that should address the issue in the action. Maybe after the next release of the actions/setup-python with the fix included, it would be resolved?

cc @jtpio, @krassowski for feedback and thoughts

@krassowski
Copy link
Member

Jumping across actions/setup-python versions should be mostly painless, there were not many breaking changes with the default options.

@jtpio
Copy link
Member
jtpio commented May 1, 2024

Maybe we could also just ignore that duplicate file error for now, to be able to move forward with the release?

For reference this was also an issue with the JupyterLab extension cookiecutter, which still has it ignored here:

https://github.com/jupyterlab/extension-cookiecutter-ts/blob/4111b5d2fb7981ec4af3c4694b7b7ae6134bf497/%7B%7Bcookiecutter.python_name%7D%7D/pyproject.toml#L87-L88

…files"

This reverts commit 9145ed5.

ignore check wheel contents duplicate file check
@RRosio RRosio changed the title Modify test file to avoid check-wheel-content duplicate file error Ignore check-wheel-content duplicate file error May 1, 2024
@RRosio
Copy link
Collaborator Author
RRosio commented May 1, 2024

Thank you both for your feedback! I have updated this PR to ignore the check and since the CI failures are not related to the PR I will go ahead and merge this and continue with the release.

@RRosio RRosio merged commit e1723f4 into jupyter:6.5.x May 1, 2024
13 of 31 checks passed
@RRosio RRosio deleted the duplicate_file branch May 1, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants