[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ldapauthenticator.py #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ldapauthenticator.py #226

wants to merge 1 commit into from

Conversation

hammadab
Copy link

Solution to #225

When escape_userdn = True the ldapauthenticator escapes special chars in userdn but does not escapes special chars in username. This does not cause an issue when allowed_groups is null but it does cause an issue when allowed_groups is not null. I suggest that the username is also escaped when escape_userdn = True or add another parameter dedicated to escape username

@welcome
Copy link
welcome bot commented Oct 26, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@hammadab
Copy link
Author
hammadab commented Nov 8, 2023

@consideRatio Kindly review this PR

@Nikolai-Hlubek
Copy link

We have this issue as well. Would it be possible to review this PR and if applicable merge it?

@manics
Copy link
Member
manics commented Jul 3, 2024

I'm not sure whether the behaviour implemented in this PR is to be expected or not. Based on the function name resolve_username it seems reasonable for it to return the unmodified username, and that the username should be escaped wherever it's used.

@Nikolai-Hlubek
Copy link

Hi @manics Thank you for the response. To explain a bit more, I think we have a similar issue in our organization as the OP.
We have a distinguishedName that contains a special characters with something like:
CN=David Hasseloff (The One and Only)
Due to the current escape settings, when this user logs in, he gets a 500: internal server error. I think this PR might be a fix for this issue, but I don't know if it causes other issues or is well designed for the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hammadab @Nikolai-Hlubek @manics