added README.md

removed unused methods
jarinrocks · Mar 28, 2022 · 9c2a3a4 · 9c2a3a4
1 parent 6949d2c
commit 9c2a3a4
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 15 deletions.
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/README.md b/README.md
@@ -0,0 +1,4 @@
+# MVI-Pattern
+
+* Click this link [ https://gnews.io/ ] signup and create an api-key,this wont take more than two minutes.
+  Open Constants file replace the API_KEY with your own api-key.
diff --git a/app/src/main/java/com/example/mvipattern/Constants.kt b/app/src/main/java/com/example/mvipattern/Constants.kt
@@ -1,6 +1,6 @@
 package com.example.mvipattern
 
 object Constants {
-    const val API_KEY : String = "e3f5358258e8944d4fe9698cf25d453e"
+    const val API_KEY : String = "api-key" // Replace with your api key
     const val BASE_URL : String = "https://gnews.io/api/v4/"
 }
diff --git a/app/src/main/java/com/example/mvipattern/NewsViewModel.kt b/app/src/main/java/com/example/mvipattern/NewsViewModel.kt
@@ -2,16 +2,14 @@ package com.example.mvipattern
 
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
-import com.example.mvipattern.NewsIntents
-import com.example.mvipattern.NewsStates
 import com.example.mvipattern.repository.RepositoryImpl
 import kotlinx.coroutines.channels.Channel
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.consumeAsFlow
 import kotlinx.coroutines.launch
 
-class NewsViewModel() : ViewModel() {
+class NewsViewModel : ViewModel() {
 
     val newsChannel = Channel<NewsIntents>()
 

diff --git a/app/src/main/java/com/example/mvipattern/repository/NewsService.kt b/app/src/main/java/com/example/mvipattern/repository/NewsService.kt
@@ -7,7 +7,7 @@ import retrofit2.http.GET
 
 interface NewsService {
 
-    @GET("top-headlines?token=${Constants.API_KEY}")
+    @GET("top-headlines?lang=en&token=${Constants.API_KEY}")
     suspend fun getTopHeadlines() : Response<NewsData>
 
 

diff --git a/app/src/main/java/com/example/mvipattern/repository/Repository.kt b/app/src/main/java/com/example/mvipattern/repository/Repository.kt
@@ -4,6 +4,5 @@ import com.example.mvipattern.NewsStates
 import kotlinx.coroutines.flow.Flow
 
 interface Repository {
-    suspend fun getEverything()
     suspend fun getTopHeadlines() : Flow<NewsStates>
 }
diff --git a/app/src/main/java/com/example/mvipattern/repository/RepositoryImpl.kt b/app/src/main/java/com/example/mvipattern/repository/RepositoryImpl.kt
@@ -3,11 +3,7 @@ package com.example.mvipattern.repository
 import com.example.mvipattern.NewsStates
 import kotlinx.coroutines.flow.flow
 
-class RepositoryImpl() : Repository {
-
-    override suspend fun getEverything() {
-
-    }
+class RepositoryImpl : Repository {
 
     override suspend fun getTopHeadlines() = flow {
 

diff --git a/app/src/main/java/com/example/mvipattern/repository/RetrofitClient.java b/app/src/main/java/com/example/mvipattern/repository/RetrofitClient.java
@@ -12,12 +12,11 @@
 
 public class RetrofitClient {
 
-    private Retrofit retrofit;
-    private static OkHttpClient.Builder httpClient =
+    private static final OkHttpClient.Builder httpClient =
             new OkHttpClient.Builder();
     private static RetrofitClient instance = null;
     private static NewsService service = null;
-    private static HttpLoggingInterceptor logging =
+    private static final HttpLoggingInterceptor logging =
             new HttpLoggingInterceptor();
 
     private RetrofitClient() {
@@ -33,7 +32,7 @@ private RetrofitClient() {
             // add logging as last interceptor
             httpClient.addInterceptor(logging);
         }
-        retrofit = new Retrofit.Builder().client(httpClient.build()).
+        Retrofit retrofit = new Retrofit.Builder().client(httpClient.build()).
                 baseUrl(Constants.BASE_URL)
                 .addConverterFactory(GsonConverterFactory.create())
                 .build();