[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double forward slash in *select_PCA_components()* function #10

Closed
ninimalina opened this issue Aug 18, 2021 · 1 comment
Closed

Double forward slash in *select_PCA_components()* function #10

ninimalina opened this issue Aug 18, 2021 · 1 comment

Comments

@ninimalina
Copy link

Hello,

When running the select_PCA_components() function I got the following error:
Error in editor(file = file, title = title) : argument "name" is missing, with no default
After checking the code I found an additional "/" in the Sel_PC resulting from the additional
"/".

The path was as follows: "C:/Users/.../S2A_T33NUD_20180104_Subset/SPCA//PCA/Selected_Components.txt"
Changing the following line of code:
Sel_PC <- paster(Output_Dir_Full, "/PCA/Selected_Components.txt", sep = "".
to:
Sel_PC <- paster(Output_Dir_Full, "PCA/Selected_Components.txt", sep = "".
resolved the error.

There is already a forward slash in:
Output_Dir_Full <- paste(Output_Dir, "/", Image_Name, "/", TypePCA, "/", sep = "")

I hope my explanations are clear.

Thank you for this package! I am currently looking through the code and read the papers!
This is amazing!

Best,
Niamh
@jbferet
Copy link
Owner
jbferet commented Sep 27, 2021

Hi Niamh,
Thank you for your message.
Yes indeed, as you have noticed if you went through my codes, this would deserve some work to get closer to standards and good programming practices... I am trying to get there, but the road is still long!

I recently pushed a new version of the package, and the latest corrections use file.path instead of paste, which should fix the error you identified.

Thanks a lot, it is nice to hear that you are enthusiastic about it!

Cheers,

jb

@jbferet jbferet closed this as completed Sep 27, 2021
jbferet added a commit that referenced this issue Jan 30, 2022
@jbferet
updated vignettes with vignette #10
a932f9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbferet @ninimalina