[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated String.prototype.substr() #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace deprecated String.prototype.substr() #87

wants to merge 1 commit into from

Conversation

CommanderRoot
Copy link

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

@CommanderRoot
Replace deprecated String.prototype.substr()
cc4c568 
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@etroynov
Copy link
etroynov commented Oct 4, 2023

@dougwilson pls, can you check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etroynov etroynov etroynov approved these changes

@jimmywarting jimmywarting jimmywarting approved these changes

Assignees
No one assigned
Labels
pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CommanderRoot @etroynov @jimmywarting @import-brain