[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-target against .NET 6 and .NET 8 #1349

Merged
merged 16 commits into from
Nov 22, 2023
Merged

Multi-target against .NET 6 and .NET 8 #1349

merged 16 commits into from
Nov 22, 2023

Conversation

bkoelman
Copy link
Member
@bkoelman bkoelman commented Sep 29, 2023

This PR targets the RTM versions of .NET / EF Core v8.

It currently references nightly builds of Npgsql.EntityFrameworkCore.PostgreSQL and Pomelo.EntityFrameworkCore.MySql because there are no stable releases yet that are compatible with EF Core 8.

Blocked by https://youtrack.jetbrains.com/issue/RSRP-494775/InspectCode-CleanupCode-hangs-on-.NET-8-RTM.

QUALITY CHECKLIST

@bkoelman bkoelman force-pushed the multi-target-net8-ef8 branch 3 times, most recently from bd9ba65 to 6fe440e Compare September 29, 2023 23:42
@codecov
Copy link
codecov bot commented Sep 29, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c1b911f) 90.79% compared to head (9546bcb) 90.81%.

❗ Current head 9546bcb differs from pull request most recent head dea63fd. Consider uploading reports for the commit dea63fd to get more accurate results

Files Patch % Lines
...onApiDotNetCore.Annotations/CollectionConverter.cs 62.50% 2 Missing and 1 partial ⚠️
...re/Queries/QueryableBuilding/WhereClauseBuilder.cs 80.00% 1 Missing and 1 partial ⚠️
src/Examples/DapperExample/SystemClock.cs 0.00% 1 Missing ⚠️
...sonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs 0.00% 1 Missing ⚠️
...etCore/QueryStrings/FieldChains/MatchTraceScope.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   90.79%   90.81%   +0.01%     
==========================================
  Files         342      342              
  Lines       11069    11058      -11     
  Branches     1811     1812       +1     
==========================================
- Hits        10050    10042       -8     
- Misses        667      668       +1     
+ Partials      352      348       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman force-pushed the multi-target-net8-ef8 branch 2 times, most recently from b57ff60 to 1a79f47 Compare October 2, 2023 21:56
@bkoelman bkoelman force-pushed the multi-target-net8-ef8 branch 3 times, most recently from 2a6f07f to 4eebd1a Compare October 9, 2023 19:19
@bkoelman bkoelman force-pushed the multi-target-net8-ef8 branch 2 times, most recently from cc79f13 to eebec66 Compare October 27, 2023 02:19
@bkoelman bkoelman force-pushed the multi-target-net8-ef8 branch 10 times, most recently from 4a04823 to 4395b92 Compare November 14, 2023 14:38
@bkoelman bkoelman force-pushed the multi-target-net8-ef8 branch 6 times, most recently from d5f56b4 to b9768dd Compare November 21, 2023 22:20
@bkoelman bkoelman marked this pull request as ready for review November 22, 2023 00:14
@bkoelman bkoelman merged commit 2835473 into master Nov 22, 2023
12 checks passed
@bkoelman bkoelman deleted the multi-target-net8-ef8 branch November 22, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant