[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics support #857

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Add metrics support #857

merged 1 commit into from
Jun 10, 2022

Conversation

s1061123
Copy link
Member
@s1061123 s1061123 commented Jun 3, 2022

This change introduces prometheus metric exporter support for multus-daemon, thick plugin.

@s1061123 s1061123 requested a review from dougbtv June 3, 2022 13:42
@s1061123 s1061123 changed the title Add metrics support [WIP]Add metrics support Jun 3, 2022
@s1061123
Add metrics support
9f3e6b0 
This change introduces prometheus metric exporter support for
multus-daemon, thick plugin.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2435641716

  • 23 of 31 (74.19%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 64.114%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/server/server.go 22 30 73.33%
Totals Coverage Status
Change from base Build 2427199592: 0.1%
Covered Lines: 1867
Relevant Lines: 2912
💛 - Coveralls

@s1061123 s1061123 changed the title [WIP]Add metrics support Add metrics support Jun 3, 2022
dougbtv
dougbtv approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member
@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougbtv dougbtv merged commit 2eb5d2f into k8snetworkplumbingwg:feature/multus-4.0 Jun 10, 2022
@s1061123 s1061123 deleted the dev/metrics branch July 13, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s1061123 @coveralls @dougbtv