[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore #195

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Conversation

MichalGuzieniuk
Copy link
Contributor

This pull requests add .gitignore that specifies intentionally untracked files. In case of SRIOV CNI such files can be found at folders

  • .gopath
  • bin
  • build

@zshi-redhat
Copy link
Collaborator

@MichalGuzieniuk Would it make sense to also add other ignore rules like in device-plugin: https://www.toptal.com/developers/gitignore/api/go,macos,linux,windows,visualstudiocode ?

@MichalGuzieniuk
Copy link
Contributor Author

@MichalGuzieniuk Would it make sense to also add other ignore rules like in device-plugin: https://www.toptal.com/developers/gitignore/api/go,macos,linux,windows,visualstudiocode ?

At the beginning I only added that what I saw on my environment. Sure, I can add those auto generated rules created with that tool https://www.toptal.com/developers/gitignore it is not a bad idea.

@Eoghan1232
Copy link
Collaborator

Approval given by @zshi-redhat and myself.
Proceeding with the merge.

@Eoghan1232 Eoghan1232 merged commit 4465f17 into k8snetworkplumbingwg:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants