[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Cache the DiscoveryClient for cli command. #6091

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Chore: Cache the DiscoveryClient for cli command. #6091

merged 1 commit into from
Jun 7, 2023

Conversation

yanggangtony
Copy link
Contributor

Description of your changes

Cache the DiscoveryClient for cli command.

Signed-off-by: yanggang <gang.yang@daocloud.io>
@codecov
Copy link
codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (cacbad3) 66.43% compared to head (a9a0f5b) 66.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6091      +/-   ##
==========================================
+ Coverage   66.43%   66.46%   +0.03%     
==========================================
  Files         191      191              
  Lines       24659    24660       +1     
==========================================
+ Hits        16382    16391       +9     
+ Misses       6687     6685       -2     
+ Partials     1590     1584       -6     
Flag Coverage Δ
core-unittests 54.98% <0.00%> (-0.05%) ⬇️
e2e-multicluster-test 31.07% <0.00%> (+0.11%) ⬆️
e2etests 33.47% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/common/args.go 32.67% <0.00%> (-0.33%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit 30bc8c9 into kubevela:master Jun 7, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants