-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macvtap deprecation #10924
Macvtap deprecation #10924
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the change in the API: schema.go
?
@@ -21,7 +21,6 @@ package deprecation | |||
|
|||
import ( | |||
"fmt" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep it.
6937b65
to
234e436
Compare
/test pull-kubevirt-build |
68b74e3
to
1957fcb
Compare
/test pull-kubevirt-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
We need to reason for this deprecation as we did with the passt
binding and suggest the alternative.
Please summarize the reasoning and alternative in the description of this PR.
Also, it makes sense to let the community a chance to feedback on such an action.
Warn that macvtap binding is going to be removed and macvtap binding plugin can be used instead. Signed-off-by: Alona Paz <alkaplan@redhat.com>
Signed-off-by: Alona Paz <alkaplan@redhat.com>
1957fcb
to
bdc853b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlonaKaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@AlonaKaplan: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
What this PR does / why we need it:
Following the introduction of Kubevirt Network Binding Plugin API [1] and of Macvtap network binding plugin [2], it's now possible to remove Macvtap network binding implementation from Kubevirt core.
The transition will be conducted in two phases across the next two releases:
Phase 1 (v1.2) - Kubevirt will raise a warning when the Macvtap interface is being used - this PR.
Phase 2 (v1.3) - Macvtap interface API will stop being supported by kubevirt (using the API will lead to no-op).
[1] https://kubevirt.io/user-guide/virtual_machines/network_binding_plugins
[2] https://kubevirt.io/user-guide/virtual_machines/net_binding_plugins/macvtap
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: