-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.2] cmd, cniplugins, passt-binding: Build the binary statically #11656
[release-1.2] cmd, cniplugins, passt-binding: Build the binary statically #11656
Conversation
The custom CNI plugin that is used with the `passt` network binding plugin is distributed through the release assets. In order to allow it to run on different platforms, build it statically to avoid shared library conflicts. This change should resolve issues [1] reported by users when attempting to use the `passt` binding plugin. [1] kubevirt#11586 Signed-off-by: Edward Haas <edwardh@redhat.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlonaKaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
1 similar comment
/retest-required |
@kubevirt-bot: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
This is an automated cherry-pick of #11653
/assign EdDev