[release-1.2] Fix RerunOnFailure RunStrategy #11972
Conversation
Simplify function by returning early on error. Signed-off-by: Antonio Cardace <acardace@redhat.com> (cherry picked from commit 6b96bee) Signed-off-by: fossedihelm <ffossemo@redhat.com>
Keep track of the last used RunStrategy to correctly process the `RerunOnFailure` RunStrategy. Before this patch the usage of this API was actually broken. Signed-off-by: Antonio Cardace <acardace@redhat.com> (cherry picked from commit 2645368) Signed-off-by: fossedihelm <ffossemo@redhat.com>
The name is misleading as it returns true if all expectations have been satisfied and the controller does not need to sync. Signed-off-by: Antonio Cardace <acardace@redhat.com> (cherry picked from commit 62780b6)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acardace The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@fossedihelm: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
What this PR does
This is a manual cherry-pick of #11963
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note
/cc @acardace