[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update slack channel links #3589

Merged

Conversation

thesuperzapper
Copy link
Member
@thesuperzapper thesuperzapper commented Sep 22, 2023

This PR ensures we are linking to the public Slack channels, rather than the internal working group ones.
So we don't have people asking questions in the WG channels.

  • #wg-automl replaced with #kubeflow-katib
  • #wg-training replaced with #kubeflow-training-operator

It also updates the name of the channel for KFServing to KServe, and reflects that it is now a separate project:

  • #kubeflow-kfserving renamed to #kserve

The problematic links were introduced in #3588

Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper
Copy link
Member Author

/assign @andreyvelich @terrytangyuan

Copy link
Member
@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 22, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9f3ff13 into kubeflow:master Sep 22, 2023
6 checks passed
@thesuperzapper thesuperzapper deleted the update-slack-channel-links branch September 22, 2023 05:30
@andreyvelich
Copy link
Member
andreyvelich commented Sep 22, 2023

@thesuperzapper There are not internal Slack channels.
#wg-automl and #wg-training are the updated channels where we ask our users to join.
#kubeflow-katib and #kubeflow-training-operator are the legacy channels.

@andreyvelich
Copy link
Member

@thesuperzapper Are you going to submit PR to update it back ?

@thesuperzapper
Copy link
Member Author

@andreyvelich , that is not correct, when we made those channels we were clear that the users should discuss in the #kubeflow-xxxx channels, and the working group members should discuss in #wg-xxxx.

It's also a lot less confusing, because users don't think about the working groups they think about the app they're using.

Furthermore, if you compare the member counts of each of these channels, the #kubeflow-xxxx ones have at least 2x as many members, so I would highly recommend you continue using those.

@andreyvelich
Copy link
Member
andreyvelich commented Sep 22, 2023

@thesuperzapper We've been promoting wg-training and wg-automl channels for our users for the last 3 years.
And we have 281 and 277 members in these channels. Many users actively post their questions in these channels.
For WG discussion we have separate closed channels where our working groups leads are invited.

Other channels (kubeflow-katib and kubeflow-training-operator are the legacy channels, they were created before ~5 years ago, and that is why they have more people there).
Also, our Slack channel for users in the WG Charter here: https://github.com/kubeflow/community/tree/master/wg-automl#contact

@kubeflow/wg-training-leads @tenzen-y Please comment on this thread.

@thesuperzapper
Copy link
Member Author

@andreyvelich firstly, the reason that channel is listed in your charter is because it's where you're meant to discuss working group matters .

You're not really allowed to have private channels, as the working groups are meant to operate in the open, where possible.

I would suggest that you either make your main channel open or you can just start using the official channel. (After you make your private channels open , we could rename the existing #wg-xxxx channels to #kubeflow-xxxx, if you would like, but that seems unnecessary given your private channels probably have less members).

@andreyvelich
Copy link
Member

You're not really allowed to have private channels, as the working groups are meant to operate in the open, where possible.

Why this statement is true ? I don't think we discussed it before.

(After you make your private channels open , we could rename the existing #wg-xxxx channels to #kubeflow-xxxx, if you would like, but that seems unnecessary given your private channels probably have less members).

I don't understand why we can't keep channels as wg-training, etc. ?

For example, for Manifests we have wg-manifests and for Notebooks we have wg-notebooks channel.
We should be consistent across different Kubeflow components to not confuse users.

cc @juliusvonkohout @kimwnasptd

@thesuperzapper
Copy link
Member Author
thesuperzapper commented Sep 22, 2023

The main channels for users to ask questions about Notebooks and Pipelines are

  • #kubeflow-pipelines (2999 members)
  • #kubeflow-notebooks (1289 members)

The #wg-notebooks channel is used by the working group to discuss working group matters.

Also, I'm not sure that the pipelines working group actually uses slack for this purpose so they don't have a channel as far as I can see.


The reason it's good to keep these separate is because we want people asking questions but we also don't want them interrupting our work.

And also they're going to search for channels based on the thing that they're using, rather than the working group which owns them.

@andreyvelich
Copy link
Member
andreyvelich commented Sep 22, 2023

I think, the main reason is why these channels have more users because they were created earlier (5 years ago) than WGs were established (3 years ago).
For example, Notebooks working group maintain 9 components. Do we need 9 Slack channels for users ?
Decreasing number of channels will be better I think, since users don't need to know about all existing Kubeflow Slack channels.

I am happy to discuss it during our Kubeflow Community Call to provide consistent across Kubeflow components.
cc @jbottum @james-jwu @zijianjoy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants