[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set Helm chart resource namespaces & support common labels #2807

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Explicitly set Helm chart resource namespaces & support common labels #2807

merged 1 commit into from
Jun 13, 2022

Conversation

stevehipwell
Copy link
Contributor

Description

This PR changes the chart behaviour to explicitly set the resource namespace instead of inferring it at apply time and adds support for setting common labels on all resources. I've also tidied up the chart CHANGELOG which can hopefully be kept up to date.

Fixes #2672.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2022
@stevehipwell
Copy link
Contributor Author

@vojtechmares once this is merged could you rebase #2777?

/assign @Raffo

@vojtechmares
Copy link
Contributor

@stevehipwell sure

@Raffo
Copy link
Contributor
Raffo commented Jun 13, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 60809f4 into kubernetes-sigs:master Jun 13, 2022
@vojtechmares vojtechmares mentioned this pull request Jun 13, 2022
Merged
@stevehipwell stevehipwell deleted the chart-improvements branch June 13, 2022 21:38
@domenjesenovec
Copy link
Contributor

ClusterRole & ClusterRoleBinding are non-namespaced resources:
https://kubernetes.io/docs/reference/access-authn-authz/rbac/#role-and-clusterrole

Why setting namespace on those resources?

@stevehipwell
Copy link
Contributor Author

@domenjesenovec thanks for spotting this, it's an unintentional typo due to rushing the changes in. I'll put in a PR to fix it.

@gre9ory gre9ory mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add namespacing for the helm chart template files
5 participants
@stevehipwell @vojtechmares @Raffo @k8s-ci-robot @domenjesenovec