[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBAC to be able to handle F5 VirtualServer source #3503

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Add RBAC to be able to handle F5 VirtualServer source #3503

merged 1 commit into from
Mar 30, 2023

Conversation

mikejoh
Copy link
Contributor
@mikejoh mikejoh commented Mar 27, 2023

Description
Add RBAC to be able to handle F5 VirtualServer Source. Support for F5 VirtualServers were added here: #3162.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2023
stevehipwell
stevehipwell suggested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor
@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this looks good @mikejoh but could you add a new unreleased section to the chart CHANGELOG to cover your changes so they get documented when the next release comes out.

@mikejoh mikejoh force-pushed the add-f5-virtualserver-source-rbac branch from b39e8f0 to fa797d1 Compare March 29, 2023 12:07
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2023
@mikejoh mikejoh force-pushed the add-f5-virtualserver-source-rbac branch from 8569301 to cea0905 Compare March 29, 2023 12:14
@mikejoh
Copy link
Contributor Author
mikejoh commented Mar 29, 2023

@stevehipwell Done!

@stevehipwell
Copy link
Contributor

@mikejoh could you squash your commits?

@mikejoh
Add RBAC to support F5 VirtualServer source
d2932e3 
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
@mikejoh mikejoh force-pushed the add-f5-virtualserver-source-rbac branch from cea0905 to d2932e3 Compare March 30, 2023 07:26
@mikejoh
Copy link
Contributor Author
mikejoh commented Mar 30, 2023

@mikejoh could you squash your commits?

@stevehipwell of course, done!

@stevehipwell
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 30, 2023
@stevehipwell stevehipwell mentioned this pull request Mar 30, 2023
Closed
@Raffo
Copy link
Contributor
Raffo commented Mar 30, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikejoh, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 949961a into kubernetes-sigs:master Mar 30, 2023
@mikejoh mikejoh deleted the add-f5-virtualserver-source-rbac branch March 30, 2023 08:50
@mikejoh mikejoh mentioned this pull request Mar 30, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehipwell stevehipwell stevehipwell requested changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikejoh @stevehipwell @Raffo @k8s-ci-robot