[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: Set --enable-metrics depending on controller.metrics.enabled. #10959

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Chart: Set --enable-metrics depending on controller.metrics.enabled. #10959

merged 1 commit into from
Feb 2, 2024
+50 −0

Conversation

Gacko
Copy link
Member
@Gacko Gacko commented Feb 1, 2024 •
edited
Loading

Credits to @pmint93 (#10070)!

What this PR does / why we need it:

The chart has a value controller.metrics.enabled which gives the impression of enabling or disabling the metrics collection of the controller. Actually it only controls the exposition of the metrics port to the cluster and some other resources around metrics collection, but does not enable or disable the metrics collection inside the controller.

This PR sets the --enable-metrics argument to false if controller.metrics.enabled is false, which is the default.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 1, 2024
@netlify Netlify
Copy link
netlify bot commented Feb 1, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 8defaa9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65bc1cc2c3b2ba0008d26dcb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority area/helm Issues or PRs related to helm charts approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2024
@Gacko
Copy link
Member Author
Gacko commented Feb 1, 2024

/assign @strongjz
/kind bug
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 1, 2024
@Gacko
Copy link
Member Author
Gacko commented Feb 1, 2024

I will rework the CI tests in the ci/ directory in a different PR and also include tests for this use case there.

@Gacko Gacko mentioned this pull request Feb 1, 2024
Closed
10 tasks
@ubergesundheit
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, ubergesundheit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3e740fe into kubernetes:main Feb 2, 2024
17 checks passed
@Gacko Gacko deleted the jkusp branch February 2, 2024 08:24
@Gacko
Copy link
Member Author
Gacko commented Feb 2, 2024

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #10961

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 2, 2024
Closed
@Gacko Gacko mentioned this pull request Feb 2, 2024
Merged
10 tasks
@NeckBeardPrince
Copy link

This was not a Kustomize friendly change. 😮‍💨

@strongjz
Copy link
Member

@NeckBeardPrince please open an issue and explain the issue. Thank you.

@mitulshah-suse mitulshah-suse mentioned this pull request Sep 27, 2024
Closed
@LeMyst LeMyst mentioned this pull request Sep 30, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongjz strongjz Awaiting requested review from strongjz

@ubergesundheit ubergesundheit Awaiting requested review from ubergesundheit

Assignees

@ubergesundheit ubergesundheit

@strongjz strongjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gacko @ubergesundheit @k8s-ci-robot @k8s-infra-cherrypick-robot @NeckBeardPrince @strongjz