Kick off فارسی (Persian) localization #22565
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit db8abc8 https://deploy-preview-22565--kubernetes-io-master-staging.netlify.app |
There was a problem hiding this comment.
Thanks for creating this. Can you follow the steps in https://kubernetes.io/docs/contribute/localization/ for e.g. creating the teams at org level ? Thanks
|
/retitle Add فارسی (Persian) localization (hope that's OK) |
|
I think this is a work-in-progress (it needs more work before it is ready to review); is that right @sattarfeizollahibarough? |
|
@sftim Yes, That's right and thank you for your contribution. We are working on the translation right now, however, It's mentioned that on the first step we should PR for minimum requirements. |
|
See https://kubernetes.io/docs/contribute/localization/#translating-content for a list of the translations you must complete for a new localization before it can be merged. This is still a substantial task. If you'd like to, we can help you work on a (new) branch and then send in a pull request to merge all the changes from that branch into master. Would that be useful? |
|
/retitle [WIP] Add فارسی (Persian) localization |
|
@sftim Yes you are right, working on a new branch is much more better idea. I would be appreciated if you could do that. Thank you in advance. |
|
Hi @zacharysarah and @sftim. I've been discussing about K8s Persian translations with @sattarfeizollahibarough offline for sometimes. Thanks |
Hi @kasramp, Yes you should submit the request. I can be the first sponsor. And We appreciate if @sftim can be the second sponsor. |
|
@sattarfeizollahibarough you can now change the base branch for this PR to dev-1.18-fa.1 and we can look at getting this merged. Then it will make sense to open a new long lived PR for merging dev-1.18-fa.1 into master, because you can then use the long-lived PR to preview the Persian localization. I suggest that you initially omit the owner files to get started, those can arrive in a later PR. |
|
I'd be happy to merge this. I can't review the Farsi / Persian, but I'm keen to see this move forward. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
What I might suggest @sattarfeizollahibarough is that I push a manually rebased version of this PR, and then merge that. |
| @@ -0,0 +1 @@ | |||
| <svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 214 210"><defs><style>.cls-1{fill:#316ce6;}.cls-2{fill:#09c1d1;}.cls-3{fill:#c9e9ec;}</style></defs><title>kubernetes_icons</title><rect class="cls-1" x="10.24" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="10.24" y="46.975" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="170.2" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="90.18" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="50.23" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="10.24" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="90.22" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="89.99" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="89.99" y="48.1" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="49.914" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="10.24" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="50.23" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="130.21" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="170.2" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="49.914" y="48.1" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="50.21" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="130.15" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="170.2" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="10.24" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="130.21" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="90.22" y="126.825" width="33.6" height="33.6" rx="4.158"/></svg> | |||
There was a problem hiding this comment.
I have not looked at the branch or preview. Do you need to commit the SVG files?
|
|
| --- | ||
| no_issue: true | ||
| title: setup | ||
| main_menu: true |
There was a problem hiding this comment.
nit: Does this front matter match the front matter in content/en/docs/setup/_index.md?
@sattarfeizollahibarough , ☝️ , Is there a reason to delete the three |
Hi. I just saw this comment. I'd like to see a build of this branch before merging. What is missing? |
|
Is the membership pending: |
|
Netlify doesn't build previews for that target branch. |
Sorry for the late response. Yes, I can sponsor. |
Yes, but should it? |
@kbhawkey Thank you for you kindness, @sftim and @zacharysarah sponsored me and I have already joint to the Kubernetes members. Any other membership is required? |
Nope! I'm sorry, I think it's my mistake. I will fix that. |
It is kind of weird. 😕 I couldn't find the given files ( docker.md, mirror-pod.md , and static-pod.md ) in none of the branches 🤔 |
| languagedirection = "ltr" | ||
|
|
||
| [languages.ru] | ||
| title = "Kubernetes" | ||
| description = "Первоклассная оркестрация контейнеров" | ||
| languageName = "Русский" | ||
| weight = 12 | ||
| weight = 13 |
There was a problem hiding this comment.
Currently in master repository of Kubernetes the Vietnamese and Russian languages have the same weight 11!!!
There was a problem hiding this comment.
Sorry for the confusion. I do see that there is duplication and did not realize the ordering of the
weights.
Is this what you are looking for: |
Yep, But I supposed those files should be in dev-1.18 or dev-118-ja branches, which obviously they are not! |
This is where I think a manual rebase + squash could be helpful. I can help with that if needed. |
Thank you @sftim could you help me to do that? |
Let's get the (virtual) paperwork in place first, then I can use my access as tech lead to take care of it all. |
|
/lgtm |
|
@sattarfeizollahibarough I have force-pushed dev-1.18-fa.1 as discussed. If you visit https://github.com/kubernetes/website/pull/new/dev-1.18-fa.1 you can open a pull request (I suggest you mark it as work-in-progress) to merge that into master |
This is the Persian Language documentation PR.
Thank you.