[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove glusterfs references from the docs #37697

Merged
merged 4 commits into from
Dec 2, 2022
Merged

remove glusterfs references from the docs #37697

merged 4 commits into from
Dec 2, 2022

Conversation

humblec
Copy link
Contributor
@humblec humblec commented Nov 3, 2022

we have removed glusterfs in-tree driver in this release (v1.26) via kubernetes/kubernetes#112749 .
This PR remove the references from the docs.

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 3, 2022
@netlify
Copy link
netlify bot commented Nov 3, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 0da988b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/638861013d67fe0008c0ee3a

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2022
@humblec humblec changed the title Gluster removal remove glusterfs references from the docs Nov 3, 2022
@humblec humblec mentioned this pull request Nov 3, 2022
Closed
@humblec
Copy link
Contributor Author
humblec commented Nov 3, 2022

Cc @tengqm @sftim @xing-yang

@tengqm
Copy link
Contributor
tengqm commented Nov 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a44510df2df0040fe47240e26bbabdde997225ef

sftim
sftim reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor
@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @humblec

I'd like to include glusterFS somewhere in the volumes page, so that if people search the docs, they find a match. A single sentence explaining that Kubernetes v1.25 was the last minor release with in-tree support is enough.

Please don't update any of the pages with auto-generated: true in their front matter. We'll cover those separately.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2022
@humblec
Copy link
Contributor Author
humblec commented Nov 5, 2022

Thanks @humblec

I'd like to include glusterFS somewhere in the volumes page, so that if people search the docs, they find a match. A single sentence explaining that Kubernetes v1.25 was the last minor release with in-tree support is enough.

@sftim indeed thats a good thought. I have added a note in volumes guide about the same.

Please don't update any of the pages with auto-generated: true in their front matter. We'll cover those separately.

sure

sftim
sftim reviewed Nov 5, 2022
View reviewed changes
Copy link
Contributor
@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing. Sorry.

content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
@humblec
Copy link
Contributor Author
humblec commented Nov 7, 2022

One more thing. Sorry.

nw @sftim 👍 , I committed those changes. ptal. thanks.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
@leonardpahlke
Copy link
Member

Looks like this is almost ready, @humblec this needs a rebase & another checkin by @sftim if you find the time :)

@humblec
Copy link
Contributor Author
humblec commented Nov 28, 2022

sure @leonardpahlke . let me do one more rebase :) ..

@leonardpahlke
Copy link
Member

K8s v1.26 is scheduled for less than a week, so we need to get this done as soon as possible! 🙏
cc @krol3

@humblec
removal of glusterfs references from persistent-volumes.md
cc69568 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
removal of glusterfs references from volumes.md
3eaf724 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
removal of glusterfs references from reference api guide
15c3834 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@humblec humblec requested review from sftim and removed request for tengqm, daminisatya and divya-mohan0209 December 1, 2022 04:51
@humblec
Copy link
Contributor Author
humblec commented Dec 1, 2022

K8s v1.26 is scheduled for less than a week, so we need to get this done as soon as possible! pray cc @krol3

@leonardpahlke @krol3 the PR has been rebased. we should be good to go . thanks !

@tengqm
Copy link
Contributor
tengqm commented Dec 1, 2022

@humblec Looks like the gate is not happy with the new commit? Could you pls try it again?

@humblec
Copy link
Contributor Author
humblec commented Dec 1, 2022

@humblec Looks like the gate is not happy with the new commit? Could you pls try it again?

@tengqm I just rebased the PR and fixed the conflicts. do we have pointer on what exactly causing the failure?

@tengqm
Copy link
Contributor
tengqm commented Dec 1, 2022

@humblec It smells like a transient netlify build timeout issue.
You may want to recommit this PR to trigger a new gate build.

@humblec
removal of GlusterFS references from storage-classes.md
0da988b 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author
humblec commented Dec 1, 2022

@humblec It smells like a transient netlify build timeout issue. You may want to recommit this PR to trigger a new gate build.

Cool. I have retriggered the tests @tengqm .. Thanks 👍

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f4f189f879538b535bc6327e26d64da0095d22e9

@tengqm
Copy link
Contributor
tengqm commented Dec 2, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 2, 2022
@tengqm
Copy link
Contributor
tengqm commented Dec 2, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 34c152a into kubernetes:dev-1.26 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim Awaiting requested review from sftim

Assignees

@xing-yang xing-yang

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@humblec @tengqm @k8s-ci-robot @leonardpahlke @xing-yang @sftim