tests: static checker: Add announce message #9259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaf
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks @jodh-intel, LGTM. Not crucial but maybe we want an option to suppress the output too?
dborquez
approved these changes
Mar 12, 2024
|
/test |
GabyCT
approved these changes
Mar 15, 2024
|
/retest-arm |
|
@jongwu - Is there a known issue with the ARM CI's currently? I see lots of odd error messages, such as: |
f95f4a3
to
ff1604d
Compare
|
/test |
|
@jongwu - wading through the ARM CI logs, I think the problem is that the VM's are not being set up cleanly: That directory exists, but may be empty since after lots of other errors, we get this fatal error: |
|
/retest-arm |
Move some of the common code into a setup function. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
ff1604d
to
017f6a6
Compare
|
/test |
Added an announcement message to the `static-checks.sh` script. It runs platform / architecture specific code so it would be useful to display details of the platform the checker is running on to help with debugging. Fixes: kata-containers#9258. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
017f6a6
to
577abd0
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an announcement message to the
static-checks.shscript. It runsplatform / architecture specific code so it would be useful to display
details of the platform the checker is running on to help with
debugging.
Fixes: #9258.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com