[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cache: Filter out non-printable characters from tag #9659

Conversation

stevenhorsman
Copy link
Member
  • The tags have a trailing non-printable character, which results in our cache tags having a trailing underscore e.g. ghcr.io/kata-containers/cached-artefacts/agent:ce24e9835_ For ease of use of these cached components, we should strip off the trailing underscore.

- The tags have a trailing non-printable character, which results
in our cache tags having a trailing underscore e.g. `ghcr.io/kata-containers/cached-artefacts/agent:ce24e9835_`
For ease of use of these cached components, we should strip off the trailing underscore.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label May 17, 2024
Copy link
Member
@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @stevenhorsman!

@fidencio
Copy link
Member

/test

@fidencio fidencio merged commit 94786dc into kata-containers:main May 18, 2024
296 of 485 checks passed
@stevenhorsman stevenhorsman deleted the remove-non-printable-tag-characters branch June 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants