[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation and testing fixes #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JiaT75
Copy link
Contributor
@JiaT75 JiaT75 commented Nov 12, 2021

Fixes #22

@lewisporter
Copy link

Danger. The author of this PR is a known malicious actor.

@ZLima12
Copy link
ZLima12 commented Mar 31, 2024

A couple things catch my eye on this one. First, extern is added to the declaration of seatest_simple_test_result. This may be legitimate, since a much earlier pull request mentions it. However, the liblzma backdoor works by abusing the linker, so I'd make sure anything having to do with linking gets extra scrutiny.

Also, it appears that they modified main to exit successfully where it would have exited unsuccessfully, and vice versa. I don't have background on the project to know if this makes sense or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate symbol _seatest_simple_test_result
3 participants