[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed z/OS build issue #968

Merged
merged 6 commits into from
Oct 29, 2022
Merged

Fixed z/OS build issue #968

merged 6 commits into from
Oct 29, 2022

Conversation

laijonathan
Copy link
@laijonathan laijonathan commented Oct 28, 2022

Removed the njsc -q flags from bindings.gyp for Node versions <= 16

For Node.js v18 and above, native addons will be built using clang instead of njsc/njsc++

@recrsn
Copy link
Collaborator
recrsn commented Oct 28, 2022 via email

@laijonathan
Copy link
Author

Our documentation has not been updated for Node v18 yet:

https://www.ibm.com/docs/en/sdk-nodejs-zos/16.0?topic=started-building-native-add-ons

@recrsn recrsn merged commit 11d2ddd into kelektiv:master Oct 29, 2022
kodiakhq bot pushed a commit to kula-app/OnLaunch that referenced this pull request Aug 19, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [bcrypt](https://togithub.com/kelektiv/node.bcrypt.js) | [`5.1.0` -> `5.1.1`](https://renovatebot.com/diffs/npm/bcrypt/5.1.0/5.1.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/bcrypt/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/bcrypt/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/bcrypt/5.1.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/bcrypt/5.1.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>kelektiv/node.bcrypt.js (bcrypt)</summary>

### [`v5.1.1`](https://togithub.com/kelektiv/node.bcrypt.js/releases/tag/v5.1.1)

[Compare Source](https://togithub.com/kelektiv/node.bcrypt.js/compare/v5.1.0...v5.1.1)

##### What's Changed

-   Refactored example with async await by [@&#8203;lpizzinidev](https://togithub.com/lpizzinidev) in [kelektiv/node.bcrypt.js#894
-   Fixed z/OS build issue by [@&#8203;laijonathan](https://togithub.com/laijonathan) in [kelektiv/node.bcrypt.js#968
-   Update dependencies by [@&#8203;recrsn](https://togithub.com/recrsn) in [kelektiv/node.bcrypt.js#993

##### New Contributors

-   [@&#8203;lpizzinidev](https://togithub.com/lpizzinidev) made their first contribution in [kelektiv/node.bcrypt.js#894
-   [@&#8203;laijonathan](https://togithub.com/laijonathan) made their first contribution in [kelektiv/node.bcrypt.js#968

**Full Changelog**: kelektiv/node.bcrypt.js@v5.1.0...v5.1.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kula-app/OnLaunch).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants