Simplify EventTargetMixin

kingzuo · Nov 25, 2018 · 11ef535 · 11ef535
1 parent cffb42e
commit 11ef535
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/core/util/eventtarget.js b/core/util/eventtarget.js
@@ -8,33 +8,28 @@
 
 export default class EventTargetMixin {
     constructor() {
-        this._listeners = null;
+        this._listeners = new Map();
     }
 
     addEventListener(type, callback) {
-        if (!this._listeners) {
-            this._listeners = new Map();
-        }
         if (!this._listeners.has(type)) {
             this._listeners.set(type, new Set());
         }
         this._listeners.get(type).add(callback);
     }
 
     removeEventListener(type, callback) {
-        if (!this._listeners || !this._listeners.has(type)) {
-            return;
+        if (this._listeners.has(type)) {
+            this._listeners.get(type).delete(callback);
         }
-        this._listeners.get(type).delete(callback);
     }
 
     dispatchEvent(event) {
-        if (!this._listeners || !this._listeners.has(event.type)) {
+        if (!this._listeners.has(event.type)) {
             return true;
         }
-        this._listeners.get(event.type).forEach((callback) => {
-            callback.call(this, event);
-        }, this);
+        this._listeners.get(event.type)
+            .forEach(callback => callback.call(this, event), this);
         return !event.defaultPrevented;
     }
 }