Use the classic function foo() { ... } for top level functions or f…

…unctions that depend on the scope
kingzuo · Jul 12, 2018 · 885363a · 885363a
1 parent 651c23e
commit 885363a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/po/xgettext-html b/po/xgettext-html
@@ -89,11 +89,11 @@ for (let i = 0; i < opt.argv.length; i++) {
     const dom = new jsdom.JSDOM(file, { includeNodeLocations: true });
     const body = dom.window.document.body;
 
-    const locator = (elem) => {
+    function locator(elem) {
         const offset = dom.nodeLocation(elem).startOffset;
         const line = file.slice(0, offset).split("\n").length;
         return fn + ":" + line;
-    };
+    }
 
     process(body, locator, true);
 }

diff --git a/tests/playback.js b/tests/playback.js
@@ -24,7 +24,7 @@ if (window.setImmediate === undefined) {
         _immediateFuncs[id];
     };
 
-    const _onMessage = (event) => {
+    window.addEventListener("message", (event) => {
         if ((typeof event.data !== "string") ||
             (event.data.indexOf("noVNC immediate trigger:") !== 0)) {
             return;
@@ -40,8 +40,7 @@ if (window.setImmediate === undefined) {
         delete _immediateFuncs[index];
 
         callback();
-    };
-    window.addEventListener("message", _onMessage);
+    });
 }
 
 export default class RecordingPlayer {

diff --git a/tests/test.rfb.js b/tests/test.rfb.js
@@ -23,24 +23,24 @@ import sinon from '../vendor/sinon.js';
     window.UIEvent = UIEvent;
 })();
 
-const push8 = (arr, num) => {
+function push8(arr, num) {
     "use strict";
     arr.push(num & 0xFF);
-};
+}
 
-const push16 = (arr, num) => {
+function push16(arr, num) {
     "use strict";
     arr.push((num >> 8) & 0xFF,
               num & 0xFF);
-};
+}
 
-const push32 = (arr, num) => {
+function push32(arr, num) {
     "use strict";
     arr.push((num >> 24) & 0xFF,
               (num >> 16) & 0xFF,
               (num >>  8) & 0xFF,
               num & 0xFF);
-};
+}
 
 describe('Remote Frame Buffer Protocol Client', function() {
     let clock;