help exit status 0 (ahmetb#72)

kjshomper · Aug 19, 2018 · e368d13 · e368d13
1 parent 7bc9a12
commit e368d13
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/kubectx b/kubectx
@@ -37,7 +37,6 @@ USAGE:
 
   kubectx -h,--help         : show this message
 EOF
-  exit 1
 }
 
 current_context() {
@@ -176,11 +175,13 @@ main() {
     if [[ "$#" -lt 2 ]]; then
       echo "error: missing context NAME" >&2
       usage
+      exit 1
     fi
     delete_contexts "${@:2}"
   elif [[ "$#" -gt 1 ]]; then
     echo "error: too many arguments" >&2
     usage
+    exit 1
   elif [[ "$#" -eq 1 ]]; then
     if [[ "${1}" == "-" ]]; then
       swap_context
@@ -189,13 +190,15 @@ main() {
     elif [[ "${1}" =~ ^-(.*) ]]; then
       echo "error: unrecognized flag \"${1}\"" >&2
       usage
+      exit 1
     elif [[ "${1}" =~ (.+)=(.+) ]]; then
       rename_context "${BASH_REMATCH[2]}" "${BASH_REMATCH[1]}"
     else
       set_context "${1}"
     fi
   else
     usage
+    exit 1
   fi
 }
 

diff --git a/kubens b/kubens
@@ -31,7 +31,6 @@ USAGE:
   kubens -                  : switch to the previous namespace in this context
   kubens -h,--help          : show this message
 EOF
-  exit 1
 }
 
 current_namespace() {
@@ -147,6 +146,7 @@ main() {
     elif [[ "${1}" =~ ^-(.*) ]]; then
       echo "error: unrecognized flag \"${1}\"" >&2
       usage
+      exit 1
     elif [[ "${1}" =~ (.+)=(.+) ]]; then
       alias_context "${BASH_REMATCH[2]}" "${BASH_REMATCH[1]}"
     else
@@ -155,6 +155,7 @@ main() {
   else
     echo "error: too many flags" >&2
     usage
+    exit 1
   fi
 }