test(general): set cache size limits for the repository under test used in robustness tests #3945
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3945 +/- ##
==========================================
+ Coverage 75.86% 77.16% +1.30%
==========================================
Files 470 481 +11
Lines 37301 28803 -8498
==========================================
- Hits 28299 22227 -6072
+ Misses 7071 4672 -2399
+ Partials 1931 1904 -27 ☔ View full report in Codecov by Sentry. |
…pia into robustness-cache-hard-limits
julio-lopez
reviewed
Jul 2, 2024
| @@ -67,6 +67,15 @@ func (mcs *MultiClientSnapshotter) ConnectOrCreateRepo(repoPath string) error { | |||
| return err | |||
| } | |||
|
|
|||
| // SetCacheSizeLimits sets the cache size limits for an existing repository | |||
| // the repository server is connected to. | |||
| func (mcs *MultiClientSnapshotter) SetCacheSizeLimits(cacheArgs string) error { | |||
There was a problem hiding this comment.
What is cacheArgs? it seems that an arbitrary flag can be passed.
There was a problem hiding this comment.
Added restrictions for allowed flags
| @@ -145,6 +145,13 @@ func (th *TestHarness) getSnapshotter() bool { | |||
| return false | |||
| } | |||
|
|
|||
| contentCacheLimitMB := "--content-cache-size-limit-mb=500" | |||
| metadataCacheLimitMB := "--metadata-cache-size-limit-mb=500" | |||
| if err = s.SetCacheSizeLimits(contentCacheLimitMB + metadataCacheLimitMB); err != nil { | |||
There was a problem hiding this comment.
Does this work? it seems to me that this will always return an error.
chaitalisg
commented
Jul 8, 2024
chaitalisg
commented
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The robustness tests set soft limits for content cache size and metadata cache size. This PR adds the hard limits for both the caches, thus reducing the memory required to run the robustness tests for long term.