Remove k8s-openapi version feature from kubelet #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Flansburg <kevin.flansburg@gmail.com>
6912fe0
to
355f9a2
Compare
|
Not sure what is causing the Windows E2E failure: Doesnt seem related to the changes here |
|
That seems like a kind failure of some type |
Nah - I think the article you linked is sufficient. |
thomastaylor312
approved these changes
Oct 20, 2021
|
@kflansburg There is definitely something up with the windows e2e stuff that @bacongobbler and I are trying to figure out. So I think you should be ok to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #612
I think this is all we need,
kubeletandwasi-providercrates now only specify the version feature in dev-dependencies.Our binaries are compiled with the specific version we test (1.22 right now).
I verified that I can create new project which imports
kubeletcrate, and specify a different version without issues.The only missing component is that we discussed specifying a default version, and requiring the user to turn off default features to customize their API version.
k8s-openapiis pretty explicit that libraries should not specify version features. Would it be worth reaching out to the author to get their opinion? @bacongobbler