[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lit make luvit/tap - fail: [string "bundle:deps/git/db.lua"]:402: Kind mismatch #140

Open
ghost opened this issue Nov 19, 2015 · 2 comments
Open

lit make luvit/tap - fail: [string "bundle:deps/git/db.lua"]:402: Kind mismatch #140

ghost opened this issue Nov 19, 2015 · 2 comments

Comments

@ghost
Copy link
ghost commented Nov 19, 2015

This looks like a bug:

$ lit make luvit/tap
lit version: 2.2.16
luvi version: v2.4.0
command: make luvit/tap
load config: .../.litconfig
connecting: wss://lit.luvit.io/
fetching: 1 object
fetching: 1 object
fetching: 1 object
including dependency: pretty-print (1.0.4)
fail: [string "bundle:deps/git/db.lua"]:402: Kind mismatch
stack traceback:
        [C]: in function 'assert'
        [string "bundle:deps/git/db.lua"]:402: in function 'loadAs'
        [string "bundle:libs/install-deps.lua"]:30: in function 'installDeps'
        [string "bundle:libs/core.lua"]:476: in function 'makeUrl'
        [string "bundle:/commands/make.lua"]:12: in function 'fn'
        [string "bundle:deps/require.lua"]:293: in function 'require'
        [string "bundle:main.lua"]:50: in function <[string "bundle:main.lua"]:38>
        [C]: in function 'xpcall'
        [string "bundle:main.lua"]:38: in function <[string "bundle:main.lua"]:31>
@creationix
Copy link
Member

I believe tap is a single-file package. You can't use these with lit make because it's expecting a tree with a main.lua file to act at the bootstrap for luvi code.

It's more of a case of poor error reporting than a bug. I'm not sure why it isn't triggering this path.

lit/libs/core.lua

Lines 473 to 475 in b394203

if not tagObj.type == "tree" then
error("Only tags pointing to trees are currently supported for make")
end

@creationix
Copy link
Member

Ahh, operator precedence strikes again.
not tagObj.type == "tree" is not the same as tagObj.type ~= "tree".

creationix added a commit that referenced this issue Nov 22, 2015
@creationix
Fix error reporting when an attempt is made to make a single-file pac…
573db2d 
…kage (#140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@creationix