[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codespace): enable builtin OBJID feature #6417

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix(codespace): enable builtin OBJID feature #6417

merged 2 commits into from
Jul 1, 2024

Conversation

kisvegabor
Copy link
Member

Description of the feature or fix

A clear and concise description of what the bug or new feature is.

Notes

XuNeo
XuNeo previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator
@XuNeo XuNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something wrong with ID_AUTO_ASSIGN?

@kisvegabor
Copy link
Member Author

If enabled it fails with:

/bin/ld: ./lvgl/src/core/lv_obj.o: in function `lv_obj_constructor':
/home/kisvegabor/projects/lvgl/eclipse-workspace/lv_port_pc_eclipse/Debug/../lvgl/src/core/lv_obj.c:390: undefined reference to `lv_obj_assign_id'
/bin/ld: ./lvgl/src/core/lv_obj.o: in function `lv_obj_destructor':
/home/kisvegabor/projects/lvgl/eclipse-workspace/lv_port_pc_eclipse/Debug/../lvgl/src/core/lv_obj.c:427: undefined reference to `lv_obj_free_id'
collect2: error: ld returned 1 exit status

@XuNeo
Copy link
Collaborator
XuNeo commented Jun 25, 2024

I see. Let's enable LV_USE_OBJ_ID_BUILTIN instead.

FASTSHIFT
FASTSHIFT previously approved these changes Jun 26, 2024
View reviewed changes
@kisvegabor kisvegabor dismissed stale reviews from FASTSHIFT and XuNeo via 6d1af29 June 27, 2024 11:45
@kisvegabor
Copy link
Member Author

I see. Let's enable LV_USE_OBJ_ID_BUILTIN instead.

It also works, and it'd be really better this way so people can use this feature out of the box.

@XuNeo XuNeo changed the title fix(codespace): set LV_OBJ_ID_AUTO_ASSIGN 0 fix(codespace): enable builtin OBJID feature Jun 27, 2024
@kisvegabor kisvegabor merged commit 27692a3 into lvgl:master Jul 1, 2024
19 checks passed
@kisvegabor kisvegabor deleted the fix/code-space branch July 1, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuNeo XuNeo XuNeo approved these changes

@FASTSHIFT FASTSHIFT FASTSHIFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kisvegabor @XuNeo @FASTSHIFT