feat(sdl_render): support all draw task types #6437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6410,
Description of the feature or fix
I'm working on adding support to all draw task types, but I'm facing a cache related issue. The current code crashes in
lv_example_buttonmatrix_1()
if this line is enabled:I'd like to immediately drop the cache in some case. In this case with
text_local = 1
thelabel_draw_dsc->text
will be freed later, so we cannot keep a reference to it in thedraw_dsc
saved in the cache..Other thing: In
sdl_texture_cache_compare_cb
I'd like to compare text of the label draw dsc-s withstrcmp
and not by pointer value. Can I simply returnreturn strcmp_res > 0 ? 1 : -1;
?cc @W-Mai
Notes
lv_conf_template.h
run lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py
(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.