[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using probe to check pod ready. #3345

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

zzjin
Copy link
Collaborator
@zzjin zzjin commented Jun 13, 2023

🤖 Generated by Copilot at 5b4f6da

Summary

🔒🚫🩺

This pull request refactors the adminer controller to use readiness probes and deployment status instead of endpoints for health checking and availability. It also updates the go.work.sum file, removes unnecessary RBAC permissions, and disables Elasticsearch logging for the adminer container. These changes improve the performance, security, and simplicity of the sealos project.

We are the sealos, we break the chains
We slash the endpoints, we reduce the scope
We probe the readiness, we report the status
We check the checksums, we ensure the integrity

Walkthrough

Signed-off-by: zzjin <tczzjin@gmail.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 637
✅ Successful 302
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 334
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link
codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b0a0461) 72.97% compared to head (5b4f6da) 72.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3345   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cuisongliu cuisongliu merged commit 261d85c into labring:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants