I found some lint in the coach plugin #12462
Conversation
Build Artifacts
|
|
Hi @nucleogenesis I think it would be good for @radinamatic to QA this since we're close to release. Can you please update your PR to have some concrete reviewer guidance for manual QA, even if it's just a short explanation of what the relevant regression testing would be, or drawing connections between particular parts of the UX and where code has changed? Thank you! |
|
No issues encountered while editing sections (reordering, renaming, replacing questions), but this unsightly view was displayed after deleting one from the Section settings sidebar: Delete did not complete, as when I tried to close the now empty sidebar, browser pop-up alert appeared, and when the page reloaded the section I intended to delete was still there. Second attempt to delete the section was equally unsuccessful, but this time it got me into Worth mentioning that the above errors while trying to delete a section appeared on a copy of a quiz, while the initial copy procedure produced this error in the console without any apparent consequences in the UI: Database and logs from Ubuntu 24.04 (tested in Firefox): |
|
Just to confirm that the error at deleting a section happens even when the quiz is not a copy of another, but created from scratch, with again ending with |
|
@radinamatic I've resolved the issue w/ the section deletion! So glad you caught this regression <3 |
979e360
to
cd20c0b
Compare
9499687
to
cbfe7d6
Compare
|
I've been pushing it really hard this morning with lots of edits, deletions, replacements and reordering, etc. It did behave rather egregiously, and no unsightly views occurred this time 🙂 The worst thing I could notice happened in the console, and apparently had no effect in the UI: But let's test this more thoroughly and include in the planned patch 1, just in case... |
c254642
to
dbb8f36
Compare
|
@radinamatic I think we can do one final pass here and then merge this for the patch? |
|
Yes, it's on our QA list! 👍🏽 |
|
Hi @nucleogenesis the only issue that I was able to identify here is actually an issue which I've previously reported for the 'Section settings' modal - when I add a new section and I enter a new section title or description, then I can't add any questions. The same is valid if I attempt to edit a section: Are.you.sure.you.want.to.leave.this.page.mp4 |
dbb8f36
to
2a70bff
Compare
|
Thanks @nucleogenesis - I confirm that the 'Section settings' modal is working fine now, and there are no new issues. Good to go! |
Summary
I found some lint in the coach plugin while evaluating the uses of
section_id.We're not using
section_idfor anything we shouldn't be I think.References
Closes #12195 -- noting that the issue is one that has been addressed over several PRs in the last few weeks.
Reviewer guidance
This PR makes changes that remove old and unused code for the most part, so some regression testing on: