[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RNA #33

Closed
jts opened this issue Oct 7, 2017 · 4 comments
Closed

Support for RNA #33

jts opened this issue Oct 7, 2017 · 4 comments

Comments

@jts
Copy link
Contributor
jts commented Oct 7, 2017

Hi @lh3,

I'd like to add support for direct RNA nanopore reads to minimap2. These reads have Us in their basecalled sequence rather than Ts. I'm happy to provide a PR but wanted to run the proposed solution by you first - is it enough to convert Us to Ts after reading the sequence here or would you prefer I do something else?

Jared

lh3 added a commit that referenced this issue Oct 7, 2017
@lh3
Copy link
Owner
lh3 commented Oct 7, 2017

Implemented via bf2d4f7. For the minimap2 command line, one change to sequence reading is sufficient. However, for API users who don't use bseq.c, we also need to change the char to base table seq_nt4_table[] in sketch.c.

@jts
Copy link
Contributor Author
jts commented Oct 7, 2017

Ah, right. Thanks for the quick implementation!

@lh3
Copy link
Owner
lh3 commented Oct 11, 2017

I am closing this for now. Let me if you have issues with this change. Thanks for the info. Didn't know RNA reads use "U".

@lh3 lh3 closed this as completed Oct 11, 2017
@jts
Copy link
Contributor Author
jts commented Oct 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants