Merge pull request #22 from lidofinance/feat/ci

Build: enable slither CI validation
lidofinance · Mar 6, 2024 · 2b2a829 · 2b2a829
2 parents b96a55b + ebb3303
commit 2b2a829
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 45 deletions.
diff --git a/.github/workflows/analyse.yml b/.github/workflows/analyse.yml
@@ -1,8 +1,6 @@
 name: Code Analysis
 
 on:
-  push:
-    branches: [master, develop]
   pull_request:
     branches: [master, develop]
 
@@ -63,9 +61,8 @@ jobs:
           echo 'value=present' >> $GITHUB_OUTPUT ||
           echo 'value=not' >> $GITHUB_OUTPUT
 
-#      # https://github.com/lidofinance/core/issues/1
-#      - name: Upload results.sarif file
-#        uses: github/codeql-action/upload-sarif@main
-#        if: ${{ always() && steps.results.outputs.value == 'present' }}
-#        with:
-#          sarif_file: results.sarif
+      - name: Upload results.sarif file
+        uses: github/codeql-action/upload-sarif@v3
+        if: ${{ always() && steps.results.outputs.value == 'present' }}
+        with:
+          sarif_file: results.sarif
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -0,0 +1,38 @@
+name: Tests
+
+on:
+  pull_request:
+    branches: [master, develop]
+
+jobs:
+  coverage:
+    name: Solidity coverage
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - run: corepack enable
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: "pnpm"
+
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Run Solidity coverage
+        run: pnpm test:coverage
+
+      - name: Produce the coverage report
+        uses: insightsengineering/coverage-action@v2
+        with:
+          path: ./coverage/cobertura-coverage.xml
+          publish: true
+          diff: true
+          diff-branch: master
+          diff-storage: _core_coverage_reports
+          coverage-summary-title: "Code Coverage Summary"
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -1,10 +1,6 @@
 name: Tests
 
-on:
-  push:
-    branches: [master, develop]
-  pull_request:
-    branches: [master, develop]
+on: [push]
 
 jobs:
   test:
@@ -28,35 +24,3 @@ jobs:
 
       - name: Run Hardhat Solidity tests
         run: pnpm test
-
-  coverage:
-    name: Solidity coverage
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          persist-credentials: false
-
-      - run: corepack enable
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 20
-          cache: "pnpm"
-
-      - name: Install dependencies
-        run: pnpm install
-
-      - name: Run Solidity coverage
-        run: pnpm test:coverage
-
-      - name: Produce the coverage report
-        uses: insightsengineering/coverage-action@v2
-        with:
-          path: ./coverage/cobertura-coverage.xml
-          publish: true
-          diff: true
-          diff-branch: master
-          diff-storage: _core_coverage_reports
-          coverage-summary-title: "Code Coverage Summary"