[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the pr to support dataset version ttl update #2543

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Split the pr to support dataset version ttl update #2543

merged 2 commits into from
Aug 18, 2023

Conversation

SophieGuo410
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link
codecov-commenter commented Aug 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.33% 🎉

Comparison is base (1307007) 33.05% compared to head (f998241) 33.39%.
Report is 2 commits behind head on master.

❗ Current head f998241 differs from pull request most recent head db2f45e. Consider uploading reports for the commit db2f45e to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2543      +/-   ##
============================================
+ Coverage     33.05%   33.39%   +0.33%     
- Complexity     4428     5012     +584     
============================================
  Files           794      801       +7     
  Lines         63782    63971     +189     
  Branches       7793     7803      +10     
============================================
+ Hits          21086    21362     +276     
- Misses        40479    40930     +451     
+ Partials       2217     1679     -538
Files Changed Coverage Δ
.../com/github/ambry/account/InMemAccountService.java 40.86% <0.00%> (+12.36%) ⬆️
...ava/com/github/ambry/account/mysql/DatasetDao.java 78.51% <100.00%> (+78.51%) ⬆️
.../github/ambry/account/mysql/MySqlAccountStore.java 94.44% <100.00%> (+94.44%) ⬆️

... and 544 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SophieGuo410 SophieGuo410 force-pushed the Branch_support_ttl_update_for_Dataset_version branch from a20c8bb to f998241 Compare August 18, 2023 19:56
@SophieGuo410 SophieGuo410 force-pushed the Branch_support_ttl_update_for_Dataset_version branch from f998241 to db2f45e Compare August 18, 2023 19:58
@SophieGuo410 SophieGuo410 merged commit d219385 into master Aug 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlin-linkedin justinlin-linkedin justinlin-linkedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SophieGuo410 @codecov-commenter @justinlin-linkedin