Close the request if 100 continue failed #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2793 +/- ##
=============================================
- Coverage 64.24% 31.91% -32.33%
+ Complexity 10398 5375 -5023
=============================================
Files 840 840
Lines 71755 71955 +200
Branches 8611 8652 +41
=============================================
- Hits 46099 22967 -23132
- Misses 23004 47211 +24207
+ Partials 2652 1777 -875 ☔ View full report in Codecov by Sentry. |
ca4cff3
to
428a12d
Compare
428a12d
to
e9af6de
Compare
e9af6de
to
381de82
Compare
ambry-rest/src/main/java/com/github/ambry/rest/NettyMessageProcessor.java
Outdated
Show resolved
Hide resolved
| @@ -1111,7 +1110,12 @@ public void operationComplete(ChannelFuture future) { | |||
| // in this case there is nothing more to write. | |||
| if (!writeFuture.isDone()) { | |||
| writeFuture.setSuccess(); | |||
| completeRequest(!HttpUtil.isKeepAlive(finalResponseMetadata), false); | |||
| //Don't close the request when we see 100-continue in EXPECT header. | |||
There was a problem hiding this comment.
completeRequest(!HttpUtil.isKeepAlive(finalResponseMetadata), false, !RestUtils.isPutRequestAndExpectContinue(request));
There was a problem hiding this comment.
Sure, updated.
| metrics.requestProcessingError.inc(); | ||
| if (requestInfo != null) { | ||
| onProcessingFailure(requestInfo.restRequest, requestInfo.restResponseChannel, e); | ||
| onProcessingFailure(requestInfo.restRequest, requestInfo.restResponseChannel, (Exception) e); |
There was a problem hiding this comment.
you can't convert this to an Exception if e is not an instance of Exception. you can probably add a line in the previous if statement to convert this throwable to exception. something like this
if (!(e instanceof Exception)) {
metrics.requestProcessingThrowableError.inc();
if (requestInfo != null) {
logger.error("Throwable only while processing the requests" + requestInfo.restRequest, e);
} else {
logger.error("Throwable only while processing the requests", e);
}
e = new Exception(e);
}
There was a problem hiding this comment.
you are right, fixed it.
8f959f4
to
5b8c419
Compare
justinlin-linkedin
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.