changing storeKeyconverter logic to count based logic #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 1, 2024 17:03
ambry-api/src/main/java/com/github/ambry/store/AbstractStoreKeyConverter.java
Outdated
Show resolved
Hide resolved
ambry-commons/src/test/java/com/github/ambry/store/AbstractStoreKeyConverterTest.java
Show resolved
Hide resolved
ambry-commons/src/test/java/com/github/ambry/store/AbstractStoreKeyConverterTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tryDropCache for keys in StoreKeyConverter to try and drop some keys.
Adding an AbstractStoreKeyConverter and implementing in current test classes of StoreKeyConverter
to have same expected logic everywhere.
AbstractStoreKeyConverter is using a counting cache logic for keys.
Whenever a key is added its count will keep increasing, when tryDropCache is called for keys, count will decrease.
Keys will be dropped, when count becomes 0.
Rest of the behviour is same as expected