[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes getServerVersion GQL #4424

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

Nageshbansal
Copy link
Contributor
@Nageshbansal Nageshbansal commented Feb 7, 2024

Proposed changes

This PR addresses the problem with the getServerVersion GQL. Previously, there were no validations in place to verify the version of the GQL server. Consequently, the serverConfig in Mongo was empty, leading to the failure of getServerVersion.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@Nageshbansal Nageshbansal changed the title Fixes server version issue Fixes getServerVersion GQL Feb 7, 2024
Signed-off-by: nagesh bansal <nageshbansal59@gmail.com>
@Saranya-jena Saranya-jena merged commit 7e53059 into litmuschaos:master Feb 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants