-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fuzzers in utils and authorization(graphql) #4467
Conversation
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
chaoscenter/graphql/server/pkg/authorization/tests/fuzz_test.go
Outdated
Show resolved
Hide resolved
token := jwt.New(jwt.SigningMethodHS256) | ||
claims := token.Claims.(jwt.MapClaims) | ||
claims["username"] = username | ||
claims["exp"] = time.Now().Add(-time.Hour).Unix() // Set expiration time to 1 hour ago |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the time package being used in many functions, better to define the variable at a single place and pass it as function argument.
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
5b28ab9
to
8a0f124
Compare
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
…into fuzzer-test
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some fuzzing test cases failed. Can you check again, please?
chaoscenter/graphql/server/pkg/authorization/tests/fuzz_test.go
Outdated
Show resolved
Hide resolved
The ci build script is not correct and it's not running on the added TCs. Will share screenshots from my local runs |
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
@namkyu1999 I have made the directory changes, PTAL again! |
@@ -0,0 +1,81 @@ | |||
package tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Saranya-jena , this file is still in the /tests
folder. Can you change this one? Other than that LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry missed it, added the changes
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
…into fuzzer-test
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: