Added env support to enable/disable gql introspection #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Jonsy13
reviewed
May 24, 2024
chaoscenter/graphql/server/server.go
Outdated
| if err != nil { | ||
| logrus.Errorf("unable to parse boolean value %v", err) | ||
| } | ||
| if err == nil && enableIntrospection == true { |
There was a problem hiding this comment.
Do we need nil check here? Already check above
There was a problem hiding this comment.
since line 125 is not in else, even after err is not nil control will still come to line 125 as I am not returning the err in line in 123 😅
ispeakc0de
approved these changes
Jun 3, 2024
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Jun 8, 2024
* Added env support to enable/disable gql introspection Signed-off-by: Saranya-jena <saranya.jena@harness.io> * resolved comments Signed-off-by: Saranya-jena <saranya.jena@harness.io> * fixed imports Signed-off-by: Saranya-jena <saranya.jena@harness.io> * fixed build issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> --------- Signed-off-by: Saranya-jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Added an env to enable/disable the graphql introspection and by default it will be disabled.
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: