-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added necessary rbacs for invite_users and get_project_members API #4697
Conversation
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
@@ -186,6 +186,15 @@ func GetActiveProjectMembers(service services.ApplicationService) gin.HandlerFun | |||
return func(c *gin.Context) { | |||
projectID := c.Param("project_id") | |||
state := c.Param("state") | |||
err := validations.RbacValidator(c.MustGet("uid").(string), projectID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add one more check here, if the user has admin role, then user can view the information.
|
||
err := validations.RbacValidator(c.MustGet("uid").(string), projectID, | ||
validations.MutationRbacRules["getProject"], string(entities.AcceptedInvitation), service) | ||
if err != nil { | ||
if err != nil && entities.Role(userRole) != entities.RoleAdmin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add the admin check before doing RbacValidator check. If role is admin, then you dont need teh RbacValidator
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: