[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tests cases for chaoscenter web views #4248

Merged
merged 13 commits into from
Nov 22, 2023

Conversation

Freedisch
Copy link
Contributor
@Freedisch Freedisch commented Oct 30, 2023

Proposed changes

Added test cases for views in chaoscenter web

  • ErrorCheck.tsx
  • ResestPassowrd.tsx
  • Overview.tsx

image

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: freedisch <freeproduc@gmail.com>
@namkyu1999 namkyu1999 added kind/unit-test LFX-MENTORSHIP Linux Foundation Mentor ship Issue labels Oct 30, 2023
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
chaoscenter/web/src/utils/testUtils.tsx Outdated Show resolved Hide resolved
chaoscenter/web/src/utils/testUtils.tsx Outdated Show resolved Hide resolved
chaoscenter/web/src/utils/testUtils.tsx Outdated Show resolved Hide resolved
Copy link
Member
@hrishavjha hrishavjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, apart from @S-ayanide 's comments rest looks good to me. Please address them🚀

Freedisch and others added 7 commits November 15, 2023 06:16
Co-authored-by: Sayan Mondal <sayan.mondal@harness.io>
Signed-off-by: Magnim BATALE <82499435+Freedisch@users.noreply.github.com>
Co-authored-by: Sayan Mondal <sayan.mondal@harness.io>
Signed-off-by: Magnim BATALE <82499435+Freedisch@users.noreply.github.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Copy link
Member
@S-ayanide S-ayanide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S-ayanide S-ayanide merged commit 162eba1 into litmuschaos:master Nov 22, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/unit-test LFX-MENTORSHIP Linux Foundation Mentor ship Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants