-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update subscriber to use Kubernetes patch for ConfigMaps an… #4287
Conversation
…d Secrets instead of get-update Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RipulHandoo you would need to add the changes in chaoscenter
directory since with the release of Litmus 3.0, litmus-portal dir has been deprecated.
Sure, I'll make the necessary changes in this file shortly. |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Hey @Saranya-jena, I have made necessary changes in the |
Signed-off-by: Ripul Handoo <107461226+RipulHandoo@users.noreply.github.com>
…d Secrets instead of get-update
Proposed changes
In the ClusterRegister function within operations.go, I've replaced the 'update' method with 'kubernetes patch' for updating ConfigMaps and Secrets. This change involves using 'json.Marshal' to serialize the clusterData, which is then utilized in 'Patch' with 'MergePatchType' for both ConfigMap and Secret updates.
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
This PR solve's this #3944