-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple publishing packages from publishing CLIs #1778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcbouchenoire
approved these changes
Jun 28, 2024
Nice, thanks for all the additions, @marcbouchenoire 🙌 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits publishing
create-liveblocks-app
and@liveblocks/codemod
off from the rest of our public packages. Our public packages need to be strictly versioned together, but making a patch to our codemod script is not something that requires a bump to the rest of the public packages.This PR splits those up. I've moved these workspaces into a new top-level
tools/*
dir, a sibling topackages/*
. This will hopefully make it clearer they are on a separate versioning scheme. They are not dependencies that users will pin as dependencies, but just run as CLI commands.You always want to be running the latest versions of these CLI tools (i.e.
npx create-liveblocks-app@latest
), so I've settled for a versioning scheme of2.<YYYYMMDD>.0
(the last patch version can be incremented if you need to publish more than once on a single day). There is no semantic versioning here. But if ever we really must, we can by bumping the 2 to 3. I'm starting with2
as a major here, because2.1.0
is already out there, and2.20240627.0
is "higher".Fixes LB-869.