feat(runner): disable DEEPCACHE for lightning/turbo models #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
884bafa
to
ba59122
Compare
This commit ensures that people can not use the deepcache optimization with lightning and turbo models. As explained in #82 (comment) this optimization does not offer any speedup for these models while it does reduce image quality.
ba59122
to
45898e3
Compare
eliteprox
requested changes
May 31, 2024
This commit ensures that Lightning/Turbo model names with both the `-` and `_` are matched when checking whether the orchestrator loaded a Lightning/Turbo model.
eliteprox
pushed a commit
to eliteprox/ai-worker
that referenced
this pull request
Jun 9, 2024
* feat(runner): disable DEEPCACHE for lightning/turbo models This commit ensures that people can not use the deepcache optimization with lightning and turbo models. As explained in livepeer#82 (comment) this optimization does not offer any speedup for these models while it does reduce image quality. * fix: ensure correct lighthing/turbo matching This commit ensures that Lightning/Turbo model names with both the `-` and `_` are matched when checking whether the orchestrator loaded a Lightning/Turbo model.
eliteprox
pushed a commit
to eliteprox/ai-worker
that referenced
this pull request
Jul 26, 2024
* feat(runner): disable DEEPCACHE for lightning/turbo models This commit ensures that people can not use the deepcache optimization with lightning and turbo models. As explained in livepeer#82 (comment) this optimization does not offer any speedup for these models while it does reduce image quality. * fix: ensure correct lighthing/turbo matching This commit ensures that Lightning/Turbo model names with both the `-` and `_` are matched when checking whether the orchestrator loaded a Lightning/Turbo model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that people can not use the deepcache optimization with lightning and turbo models. As explained in #82 (comment) this optimization does not offer any speedup for these models while it does reduce image quality.